New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: Helm Chart uses "ibm-blockchain-*-pvc" for both PV (and PVC) #95

Open

DazWilkin opened this issue Jun 6, 2018 · 0 comments

DazWilkin commented Jun 6, 2018

Recommend:

Either map names correctly to types
Or (my preference) generalize the names (removing the K8s type) perhaps:
- "shared" or "shared-volume"
- "composer" or "composer-volume"

For both Shared and Composer (although Composer is removed from Chart):

https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/_helpers.tpl#L22

https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/_helpers.tpl#L38

Shared PersistentVolume:
https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/shared-pvc.yaml#L6

Shared PersistentVolumeClaim:
https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/shared-pvc.yaml#L25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment