Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: ignore_failures heuristic should be able to be overridden on the command line #1354

Closed
kevemueller opened this issue Jan 5, 2025 · 1 comment

Comments

@kevemueller
Copy link

Brew test-bot uses complex heuristics to determine whether to set ignore_failures.
ignore_failures is set based on the state of the current formula, whether it is bottled, bottled on current version, etc.

These heuristics perform bad if the default strategy of the tap is not to bottle everything.
A command-line switch --never-ignore-failures would help to always falsify ignore_failures and hence allow unbottled formulae still to fail when tested.

This is similar to #1178, but not the same.

@kevemueller kevemueller changed the title Feature request: ignore_failures heuristic should be able to overridden on the command line Feature request: ignore_failures heuristic should be able to be overridden on the command line Jan 5, 2025
@MikeMcQuaid
Copy link
Member

Will review a PR on this but brew test-bot (and Homebrew itself) are primarily designed for workflows where bottling everything is the intent.

@MikeMcQuaid MikeMcQuaid closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants