Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Periodic boundary condition option seems deprecated #31

Open
RafaelMostert opened this issue Jul 9, 2019 · 1 comment
Open

Periodic boundary condition option seems deprecated #31

RafaelMostert opened this issue Jul 9, 2019 · 1 comment
Assignees
@BerndDoser
Milestone
2.6

Comments

@RafaelMostert
Copy link

The periodic boundary condition flag --pbc gets displayed both in the help message and at runtime Use periodic boundary conditions = 1.

Unlike in Pink version 0.23, running with or without the pbc flag makes no difference. The flag does not seem to propagate in the code beyond src/UtilitiesLib/InputData.h, is it deprecated?
@BerndDoser
Copy link
Member

BerndDoser commented Jul 9, 2019 •
edited
Loading

Yes, good point. PBC is not supported at the moment. I added a corresponding check (2bad173).

@BerndDoser BerndDoser self-assigned this Jul 17, 2019
@BerndDoser BerndDoser added this to the 2.4 milestone Dec 20, 2019
@BerndDoser BerndDoser modified the milestones: 2.4, 2.5 Feb 20, 2020
@BerndDoser BerndDoser modified the milestones: 2.5, 2.6 Apr 14, 2020
@BerndDoser BerndDoser mentioned this issue Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BerndDoser BerndDoser

Labels
None yet
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
2 participants
@BerndDoser @RafaelMostert