Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard in channel selections for spectra #251

Closed
leemundy opened this issue May 10, 2024 · 2 comments
Closed

Wildcard in channel selections for spectra #251

leemundy opened this issue May 10, 2024 · 2 comments
Assignees
Labels
beta Beta testing issue enhancement New feature or request

Comments

@leemundy
Copy link
Collaborator

Feature description
In a command like:
ta.baseline(degree=2,exclude=[(1000,3000),(5000,7000),(8500,11000)],remove=True)
You do not quickly know the first or last point in a spectrum so it would be more
convenient if there was a wildcard ability. For example,
ta.baseline(degree=2,exclude=[(,3000),(5000,7000),(8500,)],remove=True)
ta.baseline(degree=2,exclude=[(,3000),(5000,7000),(8500,)],remove=True)
Perhaps this exists but I do not know what to put to indicate -- take all channel
beyond or below a number.

Solution
If you have an idea of how to solve the problem, please describe it!

Additional context
Simplies user interaction, especially in frequency switched spectra where the area of most interest
is just the overlap region between the two negative images.

@leemundy leemundy added the enhancement New feature or request label May 10, 2024
@astrofle astrofle added the beta Beta testing issue label May 22, 2024
@teuben
Copy link
Collaborator

teuben commented May 23, 2024

I'd proposed there be an include=[(3000,5000),(7000,8500)] for this kind of case.

@teuben teuben self-assigned this May 23, 2024
@teuben
Copy link
Collaborator

teuben commented May 30, 2024

an include= was added to our Spectrum.baseline which turns an include= into exclude= and passes this on to the next baseline routine. However, for now this only works in channel space, since attaching units to baseline selection is broken, see #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Beta testing issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants