Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add resource-specific defaults/merges/overrides to modules/project-factory #2797

Open
juliocc opened this issue Jan 3, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@juliocc
Copy link
Collaborator

juliocc commented Jan 3, 2025

The feature request

The PF currently uses three variables—data_defaults, data_merges, and data_overrides—to modify project attributes. However, the PF also creates folders and billing budgets, which these variables do not affect.

Allow the project factory to modify the attributes of the other resources it creates.

Proposed solution

Two possible solutions:

  1. Rename the existing variables to be explicit about their purpose e.g. project_defaults, project_merges, project_overrides.
  2. Add top-level keys to the existing data_* variables representing the resource they alter. Something like this
variable "data_merges" {
  type = object({
    project = optional(object({...}))
    folders = optional(object({...}))
  })
}

Additional context

No response

@juliocc juliocc added the enhancement New feature or request label Jan 3, 2025
@wiktorn
Copy link
Collaborator

wiktorn commented Jan 9, 2025

It's now 3:3 (defaults, merges and overrides vs project, folders and budgets), but I vote for 2, as this will be anyway backward incompatible change. And it might grow to 3:n in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants