Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Story: Provide endpoint to search All Jobs #1897

Open
1 task
jonathanbobel opened this issue Aug 22, 2024 · 5 comments
Open
1 task

User Story: Provide endpoint to search All Jobs #1897

jonathanbobel opened this issue Aug 22, 2024 · 5 comments
Assignees
Labels
engineering python Pull requests that update Python code

Comments

@jonathanbobel
Copy link
Contributor

jonathanbobel commented Aug 22, 2024

As a [type of user],

Front-end developer

I want [an action or feature],

an endpoint for searching/filtering All Jobs on the Activity page

So that [benefit or value].

a front-end developer can finish building out the search functionality for our users

Detailed condition or criteria that must be met for the user story to be considered complete.

  • Provide an endpoint for the front-end to hit to search All Jobs
  • Make sure to filter out canceled jobs

List of specific tasks or sub-tasks that need to be done to implement the user story.

  • Create endpoint (probably in jobs.py) that provides All Jobs

List any dependencies that need to be resolved before starting or completing this user story.

No response

Any additional information or context that might be useful for the team.

Reference this PR to take a look at how the current javascript is working to filter the table, albeit just one page in the DOM (if it's paginated)

@terrazoon
Copy link
Contributor

@jonathanbobel

@github-project-automation github-project-automation bot moved this from ⬇ Up-Next to ✅ Done in Notify.gov product board Aug 26, 2024
@jonathanbobel jonathanbobel reopened this Aug 28, 2024
@ecayer ecayer moved this from ✅ Done to ⬇ Up-Next in Notify.gov product board Aug 29, 2024
@em-herrick
Copy link
Contributor

@xlorepdarkhelm Wondering what the level of effort is here to get an end-point for search.

We'd like to prioritize this for next sprint so we can close out the lingering epic related to this.

@xlorepdarkhelm
Copy link
Contributor

Example extension that can provide searching/filtering: https://exleym.github.io/Flask-Filter/

In theory, this is possible. Filtering RESTful APIs is a.... complex concept, especially when trying to build filters dynamically. The extension I linked does filtering, and sorting even. (Searching is simply filtering out the stuff that isn't what you are looking for).

I am not prescribing this extension as the solution, as thre are some issues with adding more extensions to our dependency chains. However it is probably much quicker to be set up than manually making it work. But we rise potntial for security problems with a new extension. so...

I believe this is something that might need a real spike done to track it down completely. I hesitate to guess at what the level of effort would be without further looking into the details. I will continue to look into it here and see if I can get that estimate.

@xlorepdarkhelm
Copy link
Contributor

I would say that it should be OK to add the extension in, and see where it leads, with that, I don't see this being too extremely complex to write. It could easily be done wihin a sprint, I would imagine, and then there would be searching available on this endpoint.

@em-herrick
Copy link
Contributor

Cool! Thanks for the update here—i'd love to make progress on it this sprint!

@em-herrick em-herrick moved this from ⬇ Up-Next to 🔜 Backlog in Notify.gov product board Sep 26, 2024
@sheevdave sheevdave moved this from 🔜 Backlog (Less than 3 Months) to Issue Backlog (More than 3 Months) in Notify.gov product board Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering python Pull requests that update Python code
Projects
Status: Issue Backlog (More than 3 Months)
Development

No branches or pull requests

4 participants