Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Announcement Removal Bug #1490

Closed
18 of 32 tasks
r-bartlett-gsa opened this issue Dec 19, 2024 · 4 comments · Fixed by #1501
Closed
18 of 32 tasks

Announcement Removal Bug #1490

r-bartlett-gsa opened this issue Dec 19, 2024 · 4 comments · Fixed by #1501
Assignees
Labels
bug Something isn't working

Comments

@r-bartlett-gsa
Copy link
Member

r-bartlett-gsa commented Dec 19, 2024

User story

As a challenge manager, in order to provide accurate challenge updates, I would like to be able to remove the announcements that I published earlier.

Note: this was functioning correctly at some point, but currently if I try to remove the announcement (as a challenge manager, admin or super admin), I get Not Found.

Acceptance Criteria:

  • A user (challenge manager, admin or super admin) is able to remove the announcements
  • The removed announcement is not displayed on the challenge page

Definition of Done

Doing (dev team)

  • Code complete
  • Code is organized appropriately
  • Any known trade offs are documented in the associated GH issue
  • Code is documented, modules, shared functions, etc.
    - [ ] Automated testing has been added or updated in response to changes in this PR
  • The feature is smoke tested to confirm it meets requirements
    - [ ] Database changes have been peer reviewed for index changes and performance bottlenecks
    - [ ] PR that changes or adds UI
    ~ - [ ] include a screenshot of the WAVE report for the altered pages~
    ~ - [ ] Confirm changes were validated for mobile responsiveness~
  • PR approved / Peer reviewed
  • Security scans passed
  • Automate accessibility tests passed
  • Build process and deployment is automated and repeatable
    - [ ] Feature toggles if appropriate
  • Deploy to staging
  • Move card to testing column in the board

Staging

  • Accessibility tested (Marni)
    • Keyboard navigation
    • Focus confirmed
    • Color contrast compliance
    • Screen reader testing
  • Usability testing: mobile and desktop (Tracy or Marni)
  • Cross browser testing - UI rendering is performant on below listed devices/browsers (Tracy or Marni)
    • Windows/Chrome
    • Windows/Edge
    • Mac/Chrome
    • Mac/Safari
    • iOS/Safari
  • AC review (Renata)
  • Deploy to production (production-like environment for eval capability) (dev team)
  • Move to production column in the board

Production

  • User and security documentation has been reviewed for necessary updates (Renata/Tracy/Dev team)
  • PO / PM approved (Jarah or Renata)
  • AC is met and it works as expected (Jarah or Renata)
  • Move to done column in the board (Jarah or Renata)
@r-bartlett-gsa r-bartlett-gsa added the bug Something isn't working label Dec 19, 2024
@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 12/31/24 milestone Dec 19, 2024
@r-bartlett-gsa r-bartlett-gsa linked a pull request Jan 7, 2025 that will close this issue
7 tasks
@jairoanaya
Copy link
Contributor

@r-bartlett-gsa I confirm this bug is already fixed and ready to test on Staging.

@r-bartlett-gsa
Copy link
Member Author

@jairoanaya Thank you! Please review the definition of done list and check off the items, under "doing" header that apply, and strike through the items that do not apply.

@jairoanaya
Copy link
Contributor

@r-bartlett-gsa done!

@r-bartlett-gsa
Copy link
Member Author

@jairoanaya This update is ready to go to prod. Thank you!

@kkrug kkrug linked a pull request Jan 21, 2025 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment