From 2ba362fa3b7cb8b4f4c35b016ec1c490e590b86a Mon Sep 17 00:00:00 2001 From: Elango Cheran Date: Fri, 22 Nov 2024 21:06:57 +0000 Subject: [PATCH] ICU-22921 Update PR template See #3285 --- .github/pull_request_template.md | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 2d81e299795d..62cfeb40ec1b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,25 +1,24 @@ TODO: Please describe your changes here. -TODO: Delete the following lines but _keep and fill out_ (!) the checklist below. +TODO: Please read the following on ICU Contributing, and then delete these instructions. -Thank you for your pull request!\ -General info on contributing: Please see https://github.com/unicode-org/icu/blob/main/CONTRIBUTING.md +Thank you for your pull request! -Contributors license agreement (CLA): -- You will be automatically asked to sign the CLA before the PR is accepted. -- To sign the CLA: https://cla-assistant.io/unicode-org/icu +* For general info on contributing: https://github.com/unicode-org/icu/blob/main/CONTRIBUTING.md +* Associating PRs with Jira issues + - We require each pull request to be associated with a [Jira issue](https://icu.unicode.org/bugs). + - Reuse existing issues for minor changes: + * ICU 77 docs minor fixes: ICU-22921 — User Guide & API docs typos etc., and version updates (e.g., dependabot for User Guide) + * ICU 77 code warnings/version updates: ICU-22920 — Fix compiler warnings. Update versions of code-related dependencies (e.g., dependabot). +* Contributors license agreement (CLA): + - You will be automatically asked to sign the CLA before the PR is accepted. + - To sign the CLA: https://cla-assistant.io/unicode-org/icu + - For terms of use and license, see https://www.unicode.org/terms_of_use.html -For terms of use and license, see https://www.unicode.org/terms_of_use.html - -TODO: We require each pull request to be associated with a Jira issue. -- For minor changes you can use one of the following per-release tickets: -- ICU 77 code warnings/version updates: ICU-22920 — Fix compiler warnings. Update versions of code-related dependencies (e.g., dependabot). -- ICU 77 docs minor fixes: ICU-22921 — User Guide & API docs typos etc., and version updates (e.g., dependabot for User Guide) - -TODO: End of lines to delete. +TODO: Fill out the checklist below. #### Checklist -- [ ] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-NNNNN +- [ ] Required: Issue filed: ICU-NNNNN - [ ] Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz" - [ ] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item - [ ] Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"