Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packet.json to release-version of skynet-js 4.1.0 and Gun 0.2020.1236 ! #8

Open
parajbs opened this issue Apr 23, 2022 · 2 comments

Comments

@parajbs
Copy link

parajbs commented Apr 23, 2022

Hello Fluffy9,

I noticed that you still use the 3.0.2 version of "skynet-js" in the "package.json", but the version 4.0-beta of "skynet-js" in the readme.md!
On the one hand, this is misleading and causes problems when creating the "webpack" version!

It's recently released release version 4.1.0, and works great here!

Current GunDB version is "0.2020.1236" with a few fixed bugs!

Maybe also change Readme.md to skynet-js 4.1.0?
Here the link:
https://skynet-js.hns.siasky.net/4.1/index.js

########

Furthermore I have two questions:

  1. Is the "dist" directory still necessary?
    If so, then there should also be a current version!

  2. I can also create a "webpack.config.js" incl. "packete.json" modification for webpack?
    Then the end user can create the "dist" version himself!

@parajbs
Copy link
Author

parajbs commented Apr 24, 2022

Hello Fluffy9,

I got your version 2.1.7 clone, and made some correction!

Here is the changelog:

  • corrections in "store.put" on "setJSON" ! important !
  • better debug-logs
  • update packet.json skynet-js 4.1.0 and gun 0.2020.1236
  • readme.md update link "skynet-js 4.1"
  • add webpack to packet.json
  • remove folder "dist"
  • readme.md add description to create a webpack-version!

Since I do not know myself with github, with the "Pull requests" command, the link to my branch "2.1.7 patch2", then you can view it, or maybe in your repo!

my repo:
https://github.com/parajbs/zenbase/tree/2.1.7-patch2

I hope it helps!

@parajbs
Copy link
Author

parajbs commented May 3, 2022

Hello Fluffy9,

It's me again!
I'm still trying to make it clear to you that the data in the current "Version 2.1.7" is not uploaded to "siasky.net" because in "client.db.setJSON(privateKey, key, data)" the " data" not passed as a json object!!!!
This causes an error in the Bowser console!

Here is the proof in the sdk-docs of "skynet-js":
https://sdk.skynetlabs.com/#setting-data-on-skydb

Under area "Setting Data On SkyDB" then under "Parameters" there is then:

json object The JSON object to set for the given private key and data key.

So that your project runs properly, please remove the issues!
In order to eliminate the issues, "data" must be changed to "JSON.parse(data)"! Here the solution:

client.db.setJSON(privateKey, key, JSON.parse(data))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant