From 7c87d7a2b1b1804aaaabe7000bf25b6cd0c2c56d Mon Sep 17 00:00:00 2001 From: Jon Uhlmann Date: Wed, 6 Apr 2022 13:23:27 +0200 Subject: [PATCH] BUGFIX: Fix deprecation warning with PHP 8 This removes the warning `PHP Deprecated: Required parameter $response follows optional parameter $id in Application/Flowpack.ElasticSearch/Classes/Domain/Factory/DocumentFactory.php on line 40` --- Classes/Domain/Factory/DocumentFactory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/Domain/Factory/DocumentFactory.php b/Classes/Domain/Factory/DocumentFactory.php index b9eaf1d..68fa51f 100644 --- a/Classes/Domain/Factory/DocumentFactory.php +++ b/Classes/Domain/Factory/DocumentFactory.php @@ -37,7 +37,7 @@ class DocumentFactory * @return Model\Document * @throws DocumentPropertiesMismatchException */ - public function createFromResponse(Model\AbstractType $type, $id = null, Response $response) + public function createFromResponse(Model\AbstractType $type, $id, Response $response) { $content = $response->getTreatedContent();