Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have a fix for IonAnnotationTypeDeserializer on version 2.10.x but this fix is no longer necessary on master. Should I still push it? #191

Closed
ankel opened this issue Dec 17, 2019 · 2 comments
Labels

Comments

@ankel
Copy link

ankel commented Dec 17, 2019

Hello,

I have a bug resulted from the interaction between IonObjectMapper and a plain old Json string (without class name annotated).

I have here a test and a fix for it (base on the 2.10 branch). However, on master, my fix is no longer necessary.

What is the timeline for 3.0 releases? Do you think it's still worthwhile to create a PR for this fix on for version 2.10? What are the steps for me to open a PR to that branch?

Best,

@cowtowncoder
Copy link
Member

Yes, I think fix against 2.10 branch makes sense. 3.0 (master) is not close to being released. Currently we are working on 2.11, and there will probably be further 2.x releases being developed concurrent to 3.0.

@ankel
Copy link
Author

ankel commented Dec 18, 2019

I've created #192 which contains the fix and test cases for the issue here. Resolve issue.

@ankel ankel closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants