Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize variants of JsonGenerator#writeNumberField with JsonGenerator#writeNumber #565

Closed
valery1707 opened this issue Sep 26, 2019 · 4 comments · Fixed by #566
Closed

Synchronize variants of JsonGenerator#writeNumberField with JsonGenerator#writeNumber #565

valery1707 opened this issue Sep 26, 2019 · 4 comments · Fixed by #566
Milestone
2.11.0

Comments

@valery1707
Copy link
Contributor

Currently JsonGenerator#writeNumber supports 7 types (short, int, long, BigInteger, float, double, BigDecimal) but JsonGenerator#writeNumberField support only 5 (int, long, float, double, BigDecimal).
For 2 types (short, BigInteger) we need to call JsonGenerator#writeFieldName and JsonGenerator#writeNumber rather then use one method.

Is it acceptable to create a patch with these two methods?
@cowtowncoder
Copy link
Member

Yes, that would be acceptable; that's an oversight. Since this is an API change, it will need to go in a minor version and unfortunately this just missed 2.10 (as it is being uploaded). You can make PR against master (which is for 3.0.0) and if things go well I can backport it -- there is no 2.11 created yet.

@valery1707
Copy link
Contributor Author

Good.
I will create PR soon.

@valery1707 valery1707 mentioned this issue Sep 27, 2019
Merged
@cowtowncoder
Copy link
Member

CLA received, PR ready: will wait until I create 2.11 branch (since it's an API addition), and then merge it.

Thank you for contributing this improvement!

@cowtowncoder cowtowncoder modified the milestones: 2.11., 2.11.0 Oct 5, 2019
cowtowncoder pushed a commit that referenced this issue Oct 5, 2019
@valery1707 @cowtowncoder
Fix #565: Synchronize variants of JsonGenerator#writeNumberField wi…
3bd28ae 
…th `JsonGenerator#writeNumber`
@cowtowncoder
Copy link
Member

Thank you for this contribution @valery1707 -- it will be in 2.11.0 (I created 2.11 branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.11.0
2 participants
@cowtowncoder @valery1707