Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to eslint flat config #830

Open
1 task
dec0dOS opened this issue Oct 22, 2023 · 8 comments
Open
1 task

Migrate to eslint flat config #830

dec0dOS opened this issue Oct 22, 2023 · 8 comments

Comments

@dec0dOS
Copy link

dec0dOS commented Oct 22, 2023

Hello! First of all, I want to express my appreciation for your fantastic project! It's great to see the effort and dedication put into it.

One aspect that I'd like to discuss is the configuration format used in eslint-config-hardcore. Currently, it employs a legacy configuration format that might not be as flexible and composable as the new format. This happens to be the main obstacle preventing me from using eslint-config-hardcore.

The ESLint Flat config is a significant improvement for the ecosystem, and it's encouraging to know that the transition from the legacy format is on the horizon. For more information about this exciting development, you can check out the following resources:
https://eslint.org/docs/latest/use/configure/configuration-files-new
https://eslint.org/blog/2023/10/flat-config-rollout-plans
https://www.raulmelo.me/en/blog/migration-eslint-to-flat-config
eslint/eslint#3458
eslint/eslint#10643
eslint/eslint#13481

ESLint v9 migration:

  • Remove "enforceForClassMembers": true option from no-useless-computed-key rule (it's the default in v9)
@EvgenyOrekhov
Copy link
Owner

Thanks!

Need to check whether all the configs that eslint-config-hardcore extends from support the new format.

@dec0dOS
Copy link
Author

dec0dOS commented Oct 23, 2023

Sorry, it seems like that's a duplicate of #726
It is possible to use a compatibility layer as described here: https://www.raulmelo.me/en/blog/migration-eslint-to-flat-config#official-utility-for-the-rescue

Good article, by the way. I really recommend that one.

@qweered
Copy link

qweered commented Apr 6, 2024

Now eslint 9.0 released

@The-Code-Monkey
Copy link

@EvgenyOrekhov any update on this one

@EvgenyOrekhov
Copy link
Owner

EvgenyOrekhov commented Jun 10, 2024

@The-Code-Monkey I don't have the capacity to maintain both config formats, so I'll migrate to flat config as soon as TypeScript ESLint v8 gets released and Shopify/web-configs#425 gets fixed. Or maybe even remove Shopify plugin temporarily, if they take longer.

@The-Code-Monkey
Copy link

The-Code-Monkey commented Jun 10, 2024 via email

@pmcelhaney
Copy link
Contributor

TypeScript ESLint 8.0.0 has been released. Shopify/web-configs#425 isn't closed but they did migrate to flat config.

@user72356
Copy link

user72356 commented Sep 5, 2024

Interested in this as well. It seems like all the barriers should have been removed now.

I second the need for an example of this new format in the doc, seems pretty intricate to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants