From a3c2a895d5212218a43e2bae5c2eacc459c7f8dd Mon Sep 17 00:00:00 2001
From: evg1nn <jekabkedax@gmail.com>
Date: Sat, 23 Nov 2024 19:11:11 +0300
Subject: [PATCH] Imprv. RoutesBuilder.js

Prop Destructuring: Reorganized destructuring of props for better clarity.
Default Props: Explicitly set default values for requireOnboarding using default parameters.
Logical Flow: Simplified conditional rendering for better readability.
Constants for Readability: Extracted constants from conditions for clarity.
Consistent Naming: Improved variable naming for better semantics.
Memoization: Added memoization for EntryComponent to avoid unnecessary recalculations.
---
 src/routes/RoutesBuilder.js | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/src/routes/RoutesBuilder.js b/src/routes/RoutesBuilder.js
index 4d17cfa2..7cbdaf2c 100644
--- a/src/routes/RoutesBuilder.js
+++ b/src/routes/RoutesBuilder.js
@@ -1,4 +1,4 @@
-import React, { useContext, useEffect } from 'react';
+import React, { useContext, useEffect, useMemo } from 'react';
 import { Route, Routes } from 'react-router-dom';
 import { AppContext } from '../AppProvider';
 import { getRouteComponent } from './utils';
@@ -9,20 +9,31 @@ const RoutesBuilder = ({
   routes,
   configs,
   entry,
-  requireOnboarding = true,
-  ..._
+  requireOnboarding = true, // Default value for requireOnboarding
 }) => {
   const navigate = useNavigation();
   const [{ accounts }] = useContext(AppContext);
+
+  // Check if onboarding is required and accounts are available
+  const needsOnboarding = requireOnboarding && accounts.length === 0;
+
+  // Navigate to onboarding if required
   useEffect(() => {
-    if (requireOnboarding && !accounts.length) {
+    if (needsOnboarding) {
       navigate(ROUTES_MAP.ONBOARDING);
     }
-  }, [requireOnboarding, navigate, accounts]);
+  }, [needsOnboarding, navigate]);
+
+  // Memoized computation of the entry component
+  const EntryComponent = useMemo(
+    () => (entry ? getRouteComponent(routes, entry) : null),
+    [entry, routes]
+  );
 
-  const EntryComponent = entry ? getRouteComponent(routes, entry) : null;
+  // Render routes conditionally based on onboarding status
+  if (needsOnboarding) return null;
 
-  return !requireOnboarding || (requireOnboarding && accounts.length > 0) ? (
+  return (
     <Routes>
       {EntryComponent && <Route path="/" element={<EntryComponent />} />}
       {routes.map(({ key, name, path, Component }) => (
@@ -33,7 +44,7 @@ const RoutesBuilder = ({
         />
       ))}
     </Routes>
-  ) : null;
+  );
 };
 
 export default RoutesBuilder;