Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Skill::sp_percent correctly #111

Open
mateofio opened this issue Nov 23, 2018 · 0 comments
Open

Handle Skill::sp_percent correctly #111

mateofio opened this issue Nov 23, 2018 · 0 comments
Milestone

Comments

@mateofio
Copy link
Contributor

mateofio commented Nov 23, 2018

This field defaults to 0. When in the rm2k3 editor, you select the radio button to choose percent for the first time it immediately changes to 1 and can never be set to 0 again.

We don't necessarily have to do it this way, but having both sp_type == percent && sp_percent == 0 is not a valid state.

Mentioning this as its a bit of an edge case to not forget.

@Ghabry Ghabry added this to the 0.1 milestone Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants