Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard NDP packets containing null length option #115

Open
david-marchand opened this issue Dec 23, 2024 · 1 comment
Open

Discard NDP packets containing null length option #115

david-marchand opened this issue Dec 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@david-marchand
Copy link
Member

Ref. NDP rfc:

[4.6]  Option Formats
...
      Length         8-bit unsigned integer.  The length of the option
                     (including the type and length fields) in units of
                     8 octets.  The value 0 is invalid.  Nodes MUST
                     silently discard an ND packet that contains an
                     option with length zero.
@david-marchand
Copy link
Member Author

A first part of the fix would be to break in the loop parsing options.
Yet, there are parts of grout that continue dealing with this NDP packet where the rfc says to discard the whole packet.

@rjarry rjarry added the bug Something isn't working label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants