Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue for Storage Terminal #1359

Closed
uhloin opened this issue Jul 4, 2024 · 2 comments
Closed

Performance issue for Storage Terminal #1359

uhloin opened this issue Jul 4, 2024 · 2 comments

Comments

@uhloin
Copy link

uhloin commented Jul 4, 2024

Issue type:

  • 🐌 Performance issue

Short description:

Since some size of storage opening of storage terminal with several seconds lag

Steps to reproduce the problem:

  1. Just open/close storage terminal when number of items is a bit more than one full screen
    storage is 2 colossal chests 5x5x5 with item interface
  • it's not important, is it portable or fixed storage terminal
  • size of grid is not important (lag is the same for smallest size)
  • no lags with use grid of Refined Storage mod for the same chests
  • no lags with interface of the chests (instant open/close)
  • no lags in the world when terminal is closed
  • some lags during moving mouse over grid
  • it's not important, if there are animated items in visible part
  • there are some machines working, but insertion to storage is not very big (1-10 items per second)
  • there are no crafting tasks
  • no lags during change search filter text and update grid
  • but lags between clicks to insert several stack of items from inventory to storage

I made 2 profiles for spark them opening/closing interface multiple times


Versions:

  • This mod: 1.20.1-1.22.1
  • Minecraft: 1.20.1
  • Forge: 1.20.1-47.1.100

Profiler output:

Using
https://spark.lucko.me/
integrated
spark.zip

@rubensworks
Copy link
Member

Thanks for reporting!

@rubensworks rubensworks moved this from To Do to To Do (Minor) in Maintenance Jul 13, 2024
@rubensworks
Copy link
Member

rubensworks commented Jul 16, 2024

Notes to self:

  • Lag is caused server-side during init and on updates.
  • Some of this logic can probably be moved off the main server thread.
  • Just to some profiling myself with a huge network (I can simulate one with Colossal Chests).
Screenshot 2024-07-16 at 16 36 20

rubensworks added a commit to CyclopsMC/CyclopsCore that referenced this issue Jul 22, 2024
rubensworks added a commit to CyclopsMC/IntegratedTerminals that referenced this issue Jul 22, 2024
This skips unnecessary filtering across the whole network of ingredients
every tick for when no variable-based filters are active in the
terminal.

Closes CyclopsMC/IntegratedDynamics#1359
@github-project-automation github-project-automation bot moved this from To Do (Minor) to Done in Maintenance Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants