Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make_mutable needs a parameter to control streaming #353

Open
jamesrkg opened this issue Mar 5, 2019 · 2 comments
Open

make_mutable needs a parameter to control streaming #353

jamesrkg opened this issue Mar 5, 2019 · 2 comments
Milestone

Comments

@jamesrkg
Copy link

jamesrkg commented Mar 5, 2019

scrunch/scrunch/datasets.py

Lines 992 to 994 in 4cfc508

def make_mutable(self):
from scrunch.mutable_dataset import MutableDataset
return MutableDataset(self.resource)

There is quite a bit of confusion about what mutable means, what behavior it limits, etc., but one of the biggest causes for confusion is that mutable and streaming do not appear to be mutually exclusive. For that reason make_mutable should really take a parameter for streaming that will also ensure the returned MutableDataset has the desired streaming-ness.

@jamesrkg jamesrkg added this to the Wishlist milestone Mar 5, 2019
@jamesrkg
Copy link
Author

ds.edit(streaming="no") seems to get us around this for now but an integrated solution for make_mutable would be much appreciated, as well as a FAQ/explanation about exactly what mutable and streaming, as states, are, are not and how they relate to each other.

@jamesrkg
Copy link
Author

There is a connection here that also needs to hook in for replace_from_csv, which internally needs to manage these states for the user based on whatever state it is before replace_from_csv is called. @xbito i'll take your advice about what additional ticket might be needed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant