Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find out values for EN parameters and document where they come from #63

Open
haitrec opened this issue Nov 7, 2020 · 0 comments
Open
Labels
good first issue Good for newcomers

Comments

@haitrec
Copy link
Member

haitrec commented Nov 7, 2020

Inside main/.../internal/EnFrameworkConstants.kt there are some constants set to values which have more or less been guessed. These constants are:

  • MAX_EXPOSURE_INTERPOLATION_DURATION_SECONDS
  • INTERPOLATION_ENABLED
  • MIN_BUCKETIZED_DURATION_SECONDS

Somewhere in the EN framework documentation or the google code there should be hints to which values we should set these constants. We need to find out where to find this information, set the values correctly and document (in the code), where we got the values from.
The links under "Exposure Notifications" here should help. There are also some comments in our source code already pointing to google code, where the constants are used.
Even finding and documenting the correct value for one of these constants would be a great help!

(I marked this as a good first issue since it forces one to read through the EN documentation and the google code. However, if you did not look into that yet, it might take some time to get comfortable with.)

@haitrec haitrec changed the title Find out values for constants and document where they come from Find out values for EN parameters and document where they come from Nov 7, 2020
@haitrec haitrec added the good first issue Good for newcomers label Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant