Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to remove SingleAttestation conversion and deal with it in the AggregatingAttestationPool #8930

Open
tbenr opened this issue Dec 17, 2024 · 0 comments

Comments

@tbenr
Copy link
Contributor

tbenr commented Dec 17, 2024

The current SingleAttestation conversion is a bit unclean and lead us to some stupid bugs (in publishing and in the performance calculator)

We could try to avoid that and implement single attestation handling in AggregatingAttestationPool itself (maybe actually MatchingDataAttestationGroup).
This will probably boils down to make AttestationBitsAggregator compatible to that, which will require missing bits calculated via getSingleAttestationAggregationBits to be stored in the ValidatableAttestation.

Don't know if this will end up being a better solution but could worth a try.

Note: we have to make sure we always produce an AttestationElectra when we have to produce an aggregation (thinking about the edge case where we have only one SingleAttestation in the pool)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant