Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Header in Elementor Pro affects the shop page layout #4349

Open
poonam279 opened this issue Jan 6, 2025 · 7 comments · May be fixed by #4350
Open

Custom Header in Elementor Pro affects the shop page layout #4349

poonam279 opened this issue Jan 6, 2025 · 7 comments · May be fixed by #4350
Assignees
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired..

Comments

@poonam279
Copy link

Description

When using Elementor Pro to create a custom header for the shop page, the page displays in full width regardless of the container width setting (set to "contained"). This issue overrides the intended layout and affects the shop page's appearance.

I have rolled back to version 3.8.14 and it shows the correct layout.

Step-by-step reproduction instructions

  1. Create a custom header using Elementor Pro.
  2. Assign the header to display on the shop page.
  3. Set the container width to "contained" in the theme settings.
  4. View the shop page on the front end.

Screenshots, screen recording, code snippet or Help Scout ticket

HS: https://secure.helpscout.net/conversation/2801107488/446655

Shop page with version 3.8.14
Image

Shop page with version 3.8.16
Image

Environment info

No response

Is the issue you are reporting a regression

Yes, this is a regression.

@poonam279 poonam279 added the bug This label could be used to identify issues that are caused by a defect in the product. label Jan 6, 2025
@pirate-bot pirate-bot added customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired.. labels Jan 6, 2025
@girishpanchal30 girishpanchal30 linked a pull request Jan 8, 2025 that will close this issue
6 tasks
@girishpanchal30 girishpanchal30 linked a pull request Jan 8, 2025 that will close this issue
6 tasks
@girishpanchal30
Copy link
Contributor

@poonam279 I've reviewed this issue and fixed it with this PR #4350, Please check with the build zip and let me know if you encounter any issues.

@poonam279
Copy link
Author

poonam279 commented Jan 10, 2025

@girishpanchal30 I have tested the PR but it doesn't resolve the issue.

You can check it here.
https://humgovernor.s3-tastewp.com/91fa9-pro-shop/
Admin area URL: https://humgovernor.s3-tastewp.com/wp-admin
Username: poonam
Password: PBe2-gKkIi8

@girishpanchal30
Copy link
Contributor

@poonam279 From my side, it looks like the screenshot below. Could you please share what issue occurred on your end?

Image

@girishpanchal30
Copy link
Contributor

Additionally, your test instance is missing some HTML elements, and I'm not sure why it differs from my local setup.

Image

@poonam279
Copy link
Author

@girishpanchal30, it appears that you didn't add the custom header created with elementor Pro on the shop page that's why the layout seems okay on your end. The issue occurred when we add a Elementor header on shop page. Can you please try?

@girishpanchal30
Copy link
Contributor

@poonam279 Thank you! It looks like Elementor ignored the theme's header path, causing it to miss the 'Neve' theme's header hooks. I’ve made some fixes to resolve this.

Please test with the latest build zip and let me know if you encounter any issues.

Thanks!

@poonam279
Copy link
Author

@girishpanchal30 It fixes the fullwidth layout issue but I noticed two other issues

  • content width in the customizer has no effect on the shop page
  • the left and right sidebar are not appearing as expected
Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This label could be used to identify issues that are caused by a defect in the product. customer report Indicates the request came from a customer. regression Issue represents a change in behavior from a previous version that is not intended or desired..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants