Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Bring back the domain selector? #47

Open
thekaveman opened this issue Jan 30, 2017 · 6 comments
Open

Bring back the domain selector? #47

thekaveman opened this issue Jan 30, 2017 · 6 comments
Assignees

Comments

@thekaveman
Copy link
Contributor

Related to #46, this would give users another way to view the data that may lend more/different insight.

@allejo
Copy link
Collaborator

allejo commented Feb 3, 2017

Should Jekyll generate dedicated pages for each of the domains or should we just have JS update the links for each of the charts to the respective folder of data?

@thekaveman
Copy link
Contributor Author

I think the latter (update the data inline) would be more appealing from a UI/UX point of view. What do you think?

@allejo
Copy link
Collaborator

allejo commented Feb 6, 2017

I'd be in favor of updating things in place, like you said seems cleaner

@allejo allejo self-assigned this Feb 15, 2017
@allejo
Copy link
Collaborator

allejo commented Feb 21, 2017

Preliminary support for this has begun on the feature/domain-selector-47 branch. Right now, I'm replacing all of the calls to the aggregated data to calls to individual data. However, there are some websites (e.g. Annual Report) that doesn't have "real-time" data so the "X people on City websites now" can't be updated. Thoughts?

@thekaveman
Copy link
Contributor Author

Did we exclude certain sites from real-time due to GA quotas?

In any case, can we just hide the "X people on site now" counter for those sites that don't have real-time? We can revisit why those sites don't have real-time later, if needed.

@allejo
Copy link
Collaborator

allejo commented Feb 21, 2017

Did we exclude certain sites from real-time due to GA quotas?

Yup

can we just hide the "X people on site now" counter for those sites that don't have real-time

Sure, I'll do that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants