Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edge case: halt height too close to the upgrade height #2

Open
mkaczanowski opened this issue Oct 24, 2024 · 0 comments
Open

edge case: halt height too close to the upgrade height #2

mkaczanowski opened this issue Oct 24, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@mkaczanowski
Copy link
Contributor

TL;DR

Blazar may get stuck if the node restarted (due to halt height) too close to the upgrade height. In such case, chain watcher may miss the block at which it should execute the pre-check, thus will get stuck waiting for the block till timeout expires.

The trick is that restart of a node takes some time (gated by timeout expressed in time.Duration) and the pre-checks are expressed in number of blocks.

There should be a good integration test to cover such case

@mkaczanowski mkaczanowski added bug Something isn't working enhancement New feature or request labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant