Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Add a notebook feature #10

Open
Bashamega opened this issue Feb 7, 2024 · 14 comments · May be fixed by #28
Open

Add a notebook feature #10

Bashamega opened this issue Feb 7, 2024 · 14 comments · May be fixed by #28
Assignees
Labels
Eddiehub:good-first-issue enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Bashamega
Copy link
Owner

Hello:)

Add an option that enables users to have an e-notebook.

Follow these steps to make the feature:

  1. Create the notebook feature as a boolean in the settings.json
  2. Then make a notebook icon as as svg and make it that if the boolean is true then to display it in the bar.
  3. Make the notebook functionality.
@Bashamega Bashamega added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers Eddiehub:good-first-issue labels Feb 7, 2024
@arimtiaz
Copy link

Hey! I would like to work on it!

@Bashamega
Copy link
Owner Author

Hey! I would like to work on it!

Great I will assign you

@Bashamega
Copy link
Owner Author

@arimtiaz Please create a pr!

@SeanAverS
Copy link

Hello,

I am interested on working on this. Could I please be assigned? Thank you.

@Bashamega
Copy link
Owner Author

Hello,

I am interested on working on this. Could I please be assigned? Thank you.

Done

@SeanAverS SeanAverS removed their assignment Jun 17, 2024
@yogirajbshinde21
Copy link

Hello,
May I work on this issue if it hasn't been assigned yet?
Additionally, could you please provide me with more details about the functionality from the user's perspective?

@Bashamega
Copy link
Owner Author

Hello, May I work on this issue if it hasn't been assigned yet? Additionally, could you please provide me with more details about the functionality from the user's perspective?

Assigned.
There will be a not book icon (if enabled) and when you click a popup will appear of the not book.
There will be an area for writing (A good start for the text area is the free version of the CK Editor), then you can save it in the browsers local storage. when you open it again you will find it

@yogirajbshinde21
Copy link

yogirajbshinde21 commented Jun 25, 2024

Hello @Bashamega, I build this feature, A Notebook using CK Editor which can save texts in it's local browser storage.
Currently, I have implemented this feature in default.html (the main) page only. Should I implement this feature on all pages, or is it sufficient to include it only on the default.html page?


Here's the screenshot of this feature:

Screenshot 2024-06-25 161259
In the left side, you can see a notebook icon, by click on it, a notebook appears on the right side.

@Bashamega
Copy link
Owner Author

Hello
You should add it in the pagination thing. When you move it there please open a pr

@yogirajbshinde21
Copy link

Hi @Bashamega,
Just want to confirm, feature should be implemented in this place right ?

Screenshot_20240625-170831_Chrome.jpg

@Bashamega
Copy link
Owner Author

Hi @Bashamega,
Just want to confirm, feature should be implemented in this place right ?

Screenshot_20240625-170831_Chrome.jpg

Correct

@yogirajbshinde21
Copy link

yogirajbshinde21 commented Jun 25, 2024

Hello @Bashamega ,

I have successfully implemented the notebook feature in pagination with all the necessary setup and configuration. However, I'm facing an issue where the content of CKEditor is not visible for some reason. I've spent hours trying to understand my code, watched videos, but I haven't been able to fix this specific issue. I would appreciate any suggestions you may have!


Screenshot 2024-06-25 205806


Screenshot 2024-06-25 205735

@Bashamega
Copy link
Owner Author

Hello @Bashamega ,

I have successfully implemented the notebook feature in pagination with all the necessary setup and configuration. However, I'm facing an issue where the content of CKEditor is not visible for some reason. I've spent hours trying to understand my code, watched videos, but I haven't been able to fix this specific issue. I would appreciate any suggestions you may have!


Screenshot 2024-06-25 205806


Screenshot 2024-06-25 205735

Great
Please create a pr

@yogirajbshinde21
Copy link

yogirajbshinde21 commented Jun 25, 2024

Hello @Bashamega,
I have submitted a PR that has successfully passed all checks. Please consider merging it.

@yogirajbshinde21 yogirajbshinde21 linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Eddiehub:good-first-issue enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants