Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSAL PII flag is always false #3018

Open
bgavrilMS opened this issue Sep 17, 2024 · 2 comments
Open

MSAL PII flag is always false #3018

bgavrilMS opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
bug Something isn't working P3

Comments

@bgavrilMS
Copy link
Member

Microsoft.Identity.Web Library

Microsoft.Identity.Web

Microsoft.Identity.Web version

3.10.0

Web app

Sign-in users

Web API

Protected web APIs (validating tokens)

Token cache serialization

In-memory caches

Description

There doesn't seem to be a way to set the PII flag in MSAL via Id.Web; This makes it difficult to troubleshoot some issues.

I have followed https://github.com/AzureAD/microsoft-identity-web/wiki/Logging and tried the WebAppCallGraph sample (with the setting enabled and set to true). And the mergedOptions is set to false

Reproduction steps

As per https://github.com/AzureAD/microsoft-identity-web/wiki/Logging, use this config

  "AzureAd": {
      "Instance": "https://login.microsoftonline.com/",
      "Domain": "msidlab4.onmicrosoft.com",
      "TenantId": "aaaaaa-e38d-4d1a-b510-d1b09a74a8ca",
      "ClientId": "aaaaaa-6580-4f8a-aace-f36ffea4f7be",
      "EnablePiiLogging": true

 "Logging": {
     "LogLevel": {
         "Default": "Information",
         "Microsoft": "Warning",
         "Microsoft.Hosting.Lifetime": "Information",
         "Microsoft.Identity": "Trace"
     }
 },

Actual: MSAL shows verbose logs, but not PII

Error message

No response

Id Web logs

No response

Relevant code snippets

.AddMicrosoftIdentityWebApp(options =>
{
   

    Configuration.Bind(configSection, options);
}

Regression

No response

Expected behavior

aaa

@jennyf19
Copy link
Collaborator

Are you expecting my team to pick this up?

@bgavrilMS
Copy link
Member Author

Are you expecting my team to pick this up?

I think it's a good opportunity to get this fixed by someone from MSAL team.

@bgavrilMS bgavrilMS self-assigned this Sep 26, 2024
@jennyf19 jennyf19 added P3 and removed P2 labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
None yet
Development

No branches or pull requests

2 participants