Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing CI #7719

Closed
donnapep opened this issue Jan 7, 2025 · 4 comments · Fixed by #7720
Closed

Fix failing CI #7719

donnapep opened this issue Jan 7, 2025 · 4 comments · Fixed by #7720
Assignees
@m1r0
Labels
[Pri] High Ship ASAP [Status] Triaged Issue has been triaged [Type] Bug
Milestone
4.24.5

Comments

@donnapep
Copy link
Collaborator

donnapep commented Jan 7, 2025

GitHub CI is failing. See the failing CI tasks in https://github.com/Automattic/sensei-security/pull/14.
@donnapep donnapep added [Status] Needs Triage Issue needs to be triaged [Type] Bug labels Jan 7, 2025
@donnapep donnapep added this to the 4.24.5 milestone Jan 7, 2025
@donnapep donnapep added [Status] Triaged Issue has been triaged [Pri] High Ship ASAP and removed [Status] Needs Triage Issue needs to be triaged labels Jan 7, 2025
@donnapep
Copy link
Collaborator Author

donnapep commented Jan 7, 2025

Made a start here - https://github.com/Automattic/sensei-security/pull/15.

@donnapep donnapep changed the title Fix failing CI Patchstack Vulnerability: Fix failing CI Jan 7, 2025
@donnapep donnapep changed the title Patchstack Vulnerability: Fix failing CI Fix failing CI Jan 7, 2025
@m1r0
Copy link
Member

m1r0 commented Jan 8, 2025

Should this be fixed directly in the main repo?

@donnapep
Copy link
Collaborator Author

donnapep commented Jan 8, 2025 •
edited
Loading

@m1r0 Yup, but since we're actively working in the security repo, I was hoping to fix it there first to get open PRs passing.

I also tried a super quick test to specify a specific Node version in the jobs instead, but I think the format was wrong because they didn't run at all.

@m1r0 m1r0 mentioned this issue Jan 9, 2025
Merged
7 tasks
@m1r0 m1r0 self-assigned this Jan 9, 2025
@m1r0
Copy link
Member

m1r0 commented Jan 9, 2025

I also tried a https://github.com/Automattic/sensei-security/pull/16 to specify a specific Node version in the jobs instead

We've talked about downgrading Ubuntu but I've decided to use your idea and downgraded Node instead in #7720. LMKWYT. 🙂

@m1r0 m1r0 closed this as completed in #7720 Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m1r0 m1r0

Labels
[Pri] High Ship ASAP [Status] Triaged Issue has been triaged [Type] Bug
Projects
None yet
Milestone
4.24.5
Development

Successfully merging a pull request may close this issue.

Fix CI failing because of Ubuntu update Automattic/sensei
2 participants
@donnapep @m1r0