Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Sensei and Sensei Pro on PHP 8.2 #7635

Closed
donnapep opened this issue Jul 19, 2024 · 4 comments · Fixed by #7650
Closed

Test Sensei and Sensei Pro on PHP 8.2 #7635

donnapep opened this issue Jul 19, 2024 · 4 comments · Fixed by #7650
Assignees
@m1r0
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] High Ship ASAP [Status] Triaged Issue has been triaged
Milestone
4.24.2

Comments

@donnapep
Copy link
Collaborator

  • Add define( 'WP_DEBUG_DISPLAY', true ); in wp-config.php.
  • Test all Sensei or Sensei Pro specific functionality on PHP 8.2.
  • Fix any PHP notices / errors / warnings displayed in WP admin or on the frontend.
@donnapep donnapep added [Pri] Normal Can wait for the next release [Status] Triaged Issue has been triaged labels Jul 19, 2024
@donnapep donnapep added this to the 4.24.2 milestone Jul 19, 2024
@m1r0 m1r0 self-assigned this Jul 29, 2024
@donnapep donnapep mentioned this issue Jul 29, 2024
Closed
@donnapep
Copy link
Collaborator Author

A user reported issues on PHP 8.2 in 8502623-zd-a8c.

@github-actions GitHub Actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 8502623-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Jul 29, 2024
@donnapep donnapep added [Pri] High Ship ASAP and removed [Pri] Normal Can wait for the next release labels Jul 29, 2024
@merkushin
Copy link
Member

Testing Sensei Pro PR with current Sensei trunk noticed these two warnings:

PHP Deprecated:  Using ${var} in strings is deprecated, use {$var} instead in /Users/merkushin/Developer/sensei/includes/course-theme/class-sensei-course-theme-styl
es.php on line 206

Deprecated: base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated in /Users/merkushin/Developer/sensei/includes/class-sensei-quiz.php on line 1338

@m1r0 m1r0 mentioned this issue Jul 31, 2024
Merged
15 tasks
@m1r0
Copy link
Member

m1r0 commented Jul 31, 2024

Thanks @merkushin. The warnings are fixed in #7650.

@m1r0 m1r0 closed this as completed Aug 1, 2024
@donnapep donnapep linked a pull request Aug 2, 2024 that will close this issue
Fix deprecation notices on PHP 8.2 #7650
Merged
15 tasks
@m1r0 m1r0 mentioned this issue Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m1r0 m1r0

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Pri] High Ship ASAP [Status] Triaged Issue has been triaged
Projects
None yet
Milestone
4.24.2
Development

Successfully merging a pull request may close this issue.

Fix deprecation notices on PHP 8.2 Automattic/sensei
3 participants
@merkushin @donnapep @m1r0