Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twisted 2d visualization #8

Open
justinmc opened this issue Aug 1, 2016 · 3 comments
Open

Twisted 2d visualization #8

justinmc opened this issue Aug 1, 2016 · 3 comments
Assignees

Comments

@justinmc
Copy link
Contributor

justinmc commented Aug 1, 2016

The 2d visualization can become twisted into configurations that look correct at first glance, but are actually reversed.

In these screenshots, the right right half of bipyridine is actually upside down. Notice how the selected atom in the 2d visualization corresponds to the selected atom in the 3d visualization in the first screenshot, but in the second one it's on the wrong side:
screen shot 2016-08-01 at 1 34 23 pm
screen shot 2016-08-01 at 1 34 31 pm

@avirshup
Copy link
Contributor

avirshup commented Aug 2, 2016

Yeah, that's no good! D3 v4.0 may have ways to address this - it's supposed to be much better at finding the globally optimal graph layout

@avirshup avirshup added the bug label Aug 2, 2016
@justinmc
Copy link
Contributor Author

justinmc commented Aug 2, 2016

Cool, I did a little work on upgrading to 4.0, we'll talk tomorrow.

@justinmc
Copy link
Contributor Author

justinmc commented Aug 8, 2016

@avirshup This is what happens every time I refresh the page with bipyridine in d3 v4 right now. Should be fixed with that PR if you agree (Autodesk/molecule-2d-for-react#3).

d3v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants