Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbitals not showing up #38

Open
avirshup opened this issue Nov 2, 2016 · 4 comments
Open

Orbitals not showing up #38

avirshup opened this issue Nov 2, 2016 · 4 comments
Assignees
Labels

Comments

@avirshup
Copy link
Contributor

avirshup commented Nov 2, 2016

This is in the most recent master fb2eee0 and also MDT. You'll also need to check out the visualization_json branch of MDT, or this will throw an exception because of some bad JSON.

To reproduce:

mol = mdt.from_name('benzene')
mol.set_energy_model(mdt.models.CASSCF, active_electrons=6,
                       active_orbitals=6, state_average=6, basis='sto-3g')
mol.calculate()
mol.draw_orbitals()

Then select an orbital from the dropdown list. This produces:
image

But we'd expect orbitals:
image

(the UI changes are from upgrading to ipywidgets 6.0beta. Once that project is fully stabilized, we should probably make sure the UI layouts are reasonable)

@avirshup avirshup added the bug label Nov 2, 2016
@justinmc justinmc self-assigned this Nov 3, 2016
@justinmc
Copy link
Contributor

justinmc commented Nov 3, 2016

This one is really mysterious... It seems that observing changes in the Select ipywidget isn't working. It might be a bug in the beta version of ipywidgets. I'm looking into it...

@avirshup
Copy link
Contributor Author

avirshup commented Nov 3, 2016

The select widgets have always been a little finicky in my experience. It's very weird that it changed to a dropdown, since you can see a different kind of dropdown right above it. You might check if changing it to a ipywidgets.Dropdown would get it working.

EDIT: And yeah, I'm like 70% sure that orbitals were working before upgrading to ipywidgets 6

@justinmc
Copy link
Contributor

justinmc commented Nov 3, 2016

That did it. I think it looks and works fine so here's a PR: Autodesk/molecular-design-toolkit#118

@justinmc
Copy link
Contributor

justinmc commented Nov 4, 2016

Closing this as Autodesk/molecular-design-toolkit#118 was merged. Also for the record it looks like the ipywidgets people have now fixed the original problem here: jupyter-widgets/ipywidgets#879. I was unable to confirm though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants