Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for include / exclude list on watched namespaces #28

Open
mcieplak opened this issue Mar 20, 2021 · 0 comments
Open

Support for include / exclude list on watched namespaces #28

mcieplak opened this issue Mar 20, 2021 · 0 comments
Labels
enhancement New feature or request HackTogether For Yahoo Hack Together event

Comments

@mcieplak
Copy link
Contributor

mcieplak commented Mar 20, 2021

Please describe the problem that you are trying to solve
Add command line flags to include / exclude a list of namespaces to watch and create Athenz Domain objects for.

Describe the solution you'd like
The Athenz Syncer should take in two new arguments, ns-include-list and ns-exclude-list, in order to include or exclude namespaces which it creates Athenz domain objects for. These two arguments should not coexist. If ns-include-list is set, then ns-exclude-list should not be set and vice versa.

If ns-include-list is set, we need to filter the namespaces we’re processing to only the ones specified by the parameter.

If ns-exclude-list is set, we need to exclude this set of namespaces when we’re processing any namespace updates.

This check for either parameter needs to be done in multiple places which are listed below.

  1. The namespace watch event handler when a namespace is either added, updated, or deleted.
  2. During full resync cron which does a full namespace list in order to sync all domains.
  3. When we are validating if the domain is a namespace in the controller.
  4. When we are validating a domain in the cron. Note - this should handle trust domains correctly. If the domain being processed is not a trust domain then we need to check against these command line flags.

Additional context
The Athenz Syncer currently syncs all namespaces in the entire kubernetes cluster and does not provide any way to filter this list. These two additional parameters will allow us to only sync the necessary Athenz domains to limit the amount of custom resources created on the cluster.

@mcieplak mcieplak added enhancement New feature or request HackTogether For Yahoo Hack Together event labels Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HackTogether For Yahoo Hack Together event
Projects
None yet
Development

No branches or pull requests

1 participant