You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Request for enhancement:
When performing run_checks.py on a file with no variable attributes, there is no error report that this is not ATMODAT Standard compliant.
The CF Checker writes out a warning, but no error.
It is important to report missing variable units and either long_name or standard_name as an error.
e.g.
(atmodat) angelika ~/Checker/demo_data: run_checks.py -s -f NOATTRIBUTES.nc -op checkoutput
Running Compliance Checker on the datasets from: ['NOATTRIBUTES.nc']
2021-09-03 07:40:27.459085 [INFO] :: PYESSV :: Loading vocabularies from /Users/angelika/Checker/atmodat_data_checker/AtMoDat_CVs/pyessv-archive:
2021-09-03 07:40:27.466281 [INFO] :: PYESSV :: ... loaded: atmodat
--- 4.3694 seconds for checking 1 files---
(atmodat) angelika ~/Checker/demo_data: more checkoutput/short_summary.txt
Short summary of checks:
Checking against: atmodat_standard:3.0, CF table version: 77
Version of the AtMoDat checker: 1.1.0
Checked at: 2021-09-03T09:40:31.270952
Number of checked files: 1
Total checks passed: 0/29
Mandatory checks passed: 0/2
Recommended checks passed: 0/18
Optional checks passed: 0/9
CF checker errors: 0
The text was updated successfully, but these errors were encountered:
I was thinking about this issue a little and it is relatively hard to confidently extract all data variables. It is easy to exclude the variables that define dimensions. But we still have variables that, for example, define the boundaries of coordinate variables.
For a really well-prepared netCDF file, it would be possible to exclude such special variables. This is probably not the case for a data provider, especially when first trying to prepare data for submission. In such a case, our checker would give a lot of errors, out of which some might be misleading as they go way beyond what would be required by the CF Conventions (e.g., some variables might not need units or long_name).
Overall, I think we really have to discuss if we impose the above-mentioned requirements.
I think we should at least add some summary in *CF_result.txt to shortly inform data producers and data curators on the degree of standardisation of the data variables.
For example:
No standard_name or long_name attribute specified for variables: time, ps
No units specified for variables: time, ps
Only showing
"CF checker errors: 0"
when the data variables contain no metadata is misleading.
Request for enhancement:
When performing run_checks.py on a file with no variable attributes, there is no error report that this is not ATMODAT Standard compliant.
The CF Checker writes out a warning, but no error.
It is important to report missing variable units and either long_name or standard_name as an error.
e.g.
(atmodat) angelika ~/Checker/demo_data: run_checks.py -s -f NOATTRIBUTES.nc -op checkoutput
Running Compliance Checker on the datasets from: ['NOATTRIBUTES.nc']
2021-09-03 07:40:27.459085 [INFO] :: PYESSV :: Loading vocabularies from /Users/angelika/Checker/atmodat_data_checker/AtMoDat_CVs/pyessv-archive:
2021-09-03 07:40:27.466281 [INFO] :: PYESSV :: ... loaded: atmodat
--- 4.3694 seconds for checking 1 files---
(atmodat) angelika ~/Checker/demo_data: more checkoutput/short_summary.txt
Short summary of checks:
Checking against: atmodat_standard:3.0, CF table version: 77
Version of the AtMoDat checker: 1.1.0
Checked at: 2021-09-03T09:40:31.270952
Number of checked files: 1
Total checks passed: 0/29
Mandatory checks passed: 0/2
Recommended checks passed: 0/18
Optional checks passed: 0/9
CF checker errors: 0
The text was updated successfully, but these errors were encountered: