Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST server should rate limit fetches to third party server #71

Open
ccxvii opened this issue Apr 23, 2024 · 0 comments
Open

REST server should rate limit fetches to third party server #71

ccxvii opened this issue Apr 23, 2024 · 0 comments
Assignees
Labels

Comments

@ccxvii
Copy link
Collaborator

ccxvii commented Apr 23, 2024

We do not want our example server to be able to be used as a DDOS proxy.
For each API request a user does, we issue a fetch to the third party server in the URL.
This can be used to launch a DDOS attack using our REST server's bandwidth.

Here are a few possible solutions:

  • Do not a fetch for the same file if the same URL is already being fetched.
  • Rate limit how many fetches we do to each domain.
  • Only allow fetching from a domains that is in a whitelist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants