Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistencies in find_10thetas #10

Open
imab4bsh opened this issue Jan 11, 2023 · 1 comment
Open

inconsistencies in find_10thetas #10

imab4bsh opened this issue Jan 11, 2023 · 1 comment
Labels
invalid This doesn't seem right

Comments

@imab4bsh
Copy link

imab4bsh commented Jan 11, 2023

In summer of 2020 (23-27 Jul) we (Birgit, Cécile and Kamila) had an e-mail exchange about some inconsistencies found in the find_10thetas.m script. I am opening this issue here so the discussion does not go lost and some day we fix this :)

There are two main problems:

  1. Sometimes the selected theta levels are not present in the entire time series and therefore the diagnostic plots have empty spaces. Even if the operator selects time series breaks, the function does not takes them into account.
  2. In frontal regions the selected theta levels are present in very different depths which also leads to misleading plots.
    An example (shared by Birgit) can be found here: 7900496_test_OWCall.docx

Moreover, for us it is unclear how this issues affect the further calculations of salinity differences.

@cabanesc @kamwal @BSHbirgit @apswong @gmaze
ps. should we have this discussion in our public QC forum or leave it here?

@gmaze
Copy link
Member

gmaze commented Jan 11, 2023

ps. should we have this discussion in our public QC forum or leave it here?

I think this is the perfect place to discuss this issue !

@gmaze gmaze added the invalid This doesn't seem right label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants