Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[bug]: Icon Overlap and Alphabet Input Allowed in Phone Number Field #82

Closed
4 tasks done
rahulgithub-web opened this issue Oct 2, 2024 · 5 comments · Fixed by #87
Closed
4 tasks done

🐞[bug]: Icon Overlap and Alphabet Input Allowed in Phone Number Field #82

rahulgithub-web opened this issue Oct 2, 2024 · 5 comments · Fixed by #87
Assignees
Labels

Comments

@rahulgithub-web
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When using the contact form, there are two issues:

  1. The phone number field allows users to enter alphabets instead of restricting the input to only numbers.

  2. When typing into any of the form fields, the input text overlaps with the icons placed inside the fields, causing usability issues.

Expected behavior

  1. Phone Number Field: The phone number field should restrict input to only numeric values, preventing users from entering alphabets or special characters.

  2. Icon Alignment: When a user clicks on a form field and begins typing, the text should not overlap the icon. The text input should start after the icon, keeping the icon properly aligned and separate from the input text.

Add ScreenShots

image

Current behavior (Icon Overlap):
> The input text overlaps with the icon in the email and phone fields.
image

Phone Number Issue:
Alphabets are allowed in the phone number field.
image

What browsers are you seeing the problem on?

Chrome

Record

  • I have read the Contributing Guidelines
  • I'm a GSSOC'24EXTD contributor
  • I have starred the repository
Copy link

github-actions bot commented Oct 2, 2024

Hi there! Thanks for opening this issue @rahulgithub-web!. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

@github-actions github-actions bot added the bug Something isn't working label Oct 2, 2024
@rahulgithub-web
Copy link
Contributor Author

rahulgithub-web commented Oct 2, 2024

@pand-coder @rees8 @amankumarcu @archanasingh11. Please assign this task to me

@rahulgithub-web
Copy link
Contributor Author

rahulgithub-web commented Oct 2, 2024

@archanasingh11 @pand-coder @rees8 @amankumarcu @Anjaliavv51
I have fixed the bug. Shall you please add the hacktoberfest label

@Anjaliavv51
Copy link
Owner

@archanasingh11 @pand-coder @rees8 @amankumarcu @Anjaliavv51 I have fixed the bug. Shall you please add the hacktoberfest label

I am only the maintainer here.

@rahulgithub-web
Copy link
Contributor Author

rahulgithub-web commented Oct 2, 2024

@Anjaliavv51 I understand, thank you for the clarification and your time. I appreciate your assistance and will await any further steps.

Anjaliavv51 added a commit that referenced this issue Oct 2, 2024
)

### [bug]: Icon Overlap and Alphabet Input Allowed in Phone Number Field

## Description
This pull request fixes the following issues:
1. **Icon overlap**: The input text was overlapping with the icons in
the email, phone number, and name fields. Padding has been adjusted to
ensure proper alignment between the icons and the input text.
2. **Alphabet input in the phone number field**: The phone number field
was previously accepting alphabetic characters. The input type has been
changed to `tel`, and a validation pattern has been added to restrict
input to only numeric characters.

## Related Issues
- Closes #82

## Type of PR
- [X] Bugfix

## Screenshots / Videos (if applicable)
*Before Fix:*

![image](https://github.com/user-attachments/assets/9a408c95-762e-471d-912c-f8e89f75e6d7)

*After Fix:*

![image](https://github.com/user-attachments/assets/18c54bb5-e8a6-4fea-a002-8228cfb5ab0f)

## Checklist
- [X] I have gone through the [contributing
guide](https://github.com/Anjaliavv51/Retro)
- [X] I have updated my branch and synced it with the project `main`
branch before making this PR.
- [X] I have performed a self-review of my code.
- [X] I have tested the changes thoroughly before submitting this pull
request.
- [X] I have provided relevant issue numbers, screenshots, and videos
after making the changes.
- [X] I have commented my code, particularly in hard-to-understand
areas.

## Additional Context:
None
2004shweta pushed a commit to 2004shweta/Retro that referenced this issue Oct 15, 2024
Issue Anjaliavv51#82 Services Available Section Improvised
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants