Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation when there are hidden columns. #1894

Open
DmitryMK opened this issue Feb 10, 2018 · 0 comments
Open

Keyboard navigation when there are hidden columns. #1894

DmitryMK opened this issue Feb 10, 2018 · 0 comments

Comments

@DmitryMK
Copy link

DmitryMK commented Feb 10, 2018

Hi @AllenFang, thank you for the amazing library, I love it!

It looks like there is an issue with keyboard navigation in 4.3.1 when there are hidden columns. To replicate it you can create a table with any of the columns hidden and keyboard navigation enabled. It looks like you planned for it by adding the visibleColumnSize variable, but variable 'x' still contains absolute column number.
What I did, is added an visibleColumnIndices array with indices of the non-hidden columns and made 'x' take only values from it.

Associated pull request: #1893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant