Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake build script #16

Open
madebr opened this issue Sep 25, 2024 · 2 comments
Open

CMake build script #16

madebr opened this issue Sep 25, 2024 · 2 comments

Comments

@madebr
Copy link

madebr commented Sep 25, 2024

Hey, would you be ok with adding a cmake script to the repo?
The reason I'm asking is it allows for cross-platform support,
and it would also allow easier usage on ci.

I played with caching vcpkg on GitHub actions yesterday,
but got stuck with passing vcpkg flags to the msbuild project.
With cmake and vcpkg, it would be much easier to find, and use the vcpkg dependencies.

I'd do this after #15 lands.
I'll leave it up to you to keep or remove the msbuild project,
but the cmake project should do everything the msbuild project does, and more.

@AdrienTD
Copy link
Owner

Yeah, ideally having CMake could be nice to have, but at the same time it would be a major change.
I would have to change how I open the project on my PC and also update the README etc.

I have already used CMake on some of my projects, and they can be opened directly in Visual Studio very well (maybe some small bugs here and there but hopefully fixed since then). So hopefully that won't make it harder to use compared to just open the VS project file in Visual Studio.

@madebr
Copy link
Author

madebr commented Sep 25, 2024

CMake can generate Visual Studio projects, so you'd still be able to work in the same environment.
Visual Studio 2019+ can open CMake projects immediately, or you can manually run cmake on cli once and work in VS from then on.
I'd have to boot into Windows to modify the script such that it generates nice folders for sources vs headers. I don't have used source_group before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants