Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Python==3.13 when running make build #2551

Open
asjohnston-asf opened this issue Jan 10, 2025 · 0 comments
Open

Verify Python==3.13 when running make build #2551

asjohnston-asf opened this issue Jan 10, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@asjohnston-asf
Copy link
Member

asjohnston-asf commented Jan 10, 2025

Per the README, when manually building/deploying HyP3, the user needs to make sure they're running Python v3.13 when pip installing the lambda dependencies:

  • Install Python dependencies for AWS Lambda functions (requires pip for python 3.13)
make build

Missing this step and building with a different version of python can lead to import or runtime errors when the lambda functions run with an AWS Python 3.13 runtime after being deployed.

It should be simple to assert python --version starts with 3.13 within the make build target itself, to prevent this error up front in the future.

https://github.com/ASFHyP3/hyp3/blob/develop/Makefile#L17

@asjohnston-asf asjohnston-asf added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant