Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default configuration not distributed with the gem #221

Open
1 task
afeld opened this issue Jan 29, 2021 · 1 comment
Open
1 task

default configuration not distributed with the gem #221

afeld opened this issue Jan 29, 2021 · 1 comment
Assignees
@afeld
Labels
g: final Issue ready for review. i: custom software Relating to systems built in TTS and their need for tools, guidance, security authorization, etc. t: days Should be complete-able in a matter of days or less (wall clock time)

Comments

@afeld
Copy link
Contributor

afeld commented Jan 29, 2021

Background Information

@tbaxter-18f and I noticed that the _config.yml values weren't being inherited from the released version(s) of the gem. Turns out that when you specify path: in the Gemfile, it picks up all those local files, but when released, it's only including the files and folders here:

uswds-jekyll/uswds-jekyll.gemspec

Line 13 in e93b9ab

s.files = `git ls-files -z`.split("\x0").select { |f| f.match(%r{^(assets|_layouts|_includes|_sass|LICENSE|README)}i) }

Implementation Steps

  • [ ]

Acceptance Criteria

  • Configuration inherited by sites using the theme as a released gem
@afeld afeld added g: final Issue ready for review. i: enterprise architecture t: days Should be complete-able in a matter of days or less (wall clock time) labels Jan 29, 2021
@afeld afeld self-assigned this Jan 29, 2021
@afeld afeld added i: custom software Relating to systems built in TTS and their need for tools, guidance, security authorization, etc. and removed i: enterprise architecture labels Apr 15, 2021
@adborden
Copy link
Contributor

To elaborate, theme config inheritance was added in Jekyll 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afeld afeld

Labels
g: final Issue ready for review. i: custom software Relating to systems built in TTS and their need for tools, guidance, security authorization, etc. t: days Should be complete-able in a matter of days or less (wall clock time)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afeld @adborden